Bug in news archive in vBadvanced 2.2.0

[aos101]

No one seemed to notice my mention of the bug here (http://www.vbadvanced.com/forum/showpost.php?p=91903&postcount=2), so I thought I'd put it in its own thread. The last post icon which links to the last post in the news archive is still using the old format link in vBadvanced 2.2.0, so clicking the links gives an error. The lastesttopics module seems to have been updated to the new format and latesttopics.php fetches thread.lastpostid from the database, but news.php doesn't fetch this field at all and the adv_portal_news_archivebits template hasn't been updated. I've just checked the download and the template in vbacmps_install.php still has the old format link.

I've managed to fix this myself, but the download on the site should be updated with a fix I think. To fix it:

In modules/news.php find on line 107:
thred.threadid,
And put straight after it:
thread.laspostid,
So it looks like (obviously without the '...'):
thread.threadid, thread.lastpostid, post.title, thre....
Then in the adv_portal_news_archivebits template find:
<a href="$vboptions[bburl]/showthread.php?$session[sessionurl]goto=lastpost&amp;t=$news[threadid]">
And replace with:
<a href="$vboptions[bburl]/showthread.php?$session[sessionurl]p=$news[lastpostid]#post$news[lastpostid]">
Anyone who applies this fix does so at their own risk - if it breaks your board don't blame me (my fix may be wrong, but works for me). People should wait until Brian fixes this, unless you really know what you are doing.

Edit: Changed last post link format so it works with Opera, as mentioned here (http://www.vbadvanced.com/forum/showpost.php?p=92218&postcount=29).

[aos101]

Any chance a moderator can confirm this bug and move it to Bugs & Issues?

[aos101]

Any chance a moderator can confirm this bug and move it to Bugs & Issues?
I guess not then? This bug is still present in the download. I think Brian and the moderators on here should really look at their system for reporting and getting bugs recognised, because I'm finding it really difficult to have even a simple bug in vBadvanced recognised :( .

If you are interested, these are examples of sites which exhibit this bug:

http://id-discussions.com/
http://www.iamnotageek.com/
http://joystickrequired.com/
http://www.dbstalk.com/
http://forums.operationsports.com/vBulletin/cmps_index.php
http://www.hostingzero.com/
http://www.abxzone.com/
http://www.ihateblockbuster.com/

Click the last post icon in the news archives of those sites and they all give an error because the link is the wrong format, and the templates and code in vBadvanced 2.2.0 have not been updated to the new format in the news archive.

[Zachery]

Moved.