PDA


View Full Version : Attachements display in newsbit

Cobra SA
08-30-2006, 10:15 AM
Not sure if this is a bug but attachement don't display correctly
there is no linebreak between two attachements

how can I fix this?
sgiotto
08-30-2006, 10:49 AM
I have a similar problem... I'd like tu show my attach exactly as in the post order (like image, title and text), but I can see just a link to the image "Attach 3790".

Any help for us? :D
Cobra SA
08-30-2006, 04:09 PM
Anyone investigating the matter?
Zachery
08-30-2006, 04:28 PM
It hasn't even been 12 hours, so now, However I believe that this is currently slightly a vBulletin issue. I'll need to have Brian investgate.
Cobra SA
08-30-2006, 04:57 PM
I am ok to take any fix even if that requires php files editing.
Cobra SA
08-31-2006, 05:45 PM
seems like this one is a pain in the ass :/
Cobra SA
09-24-2006, 03:07 PM
sorry for double post but....
it seems a very important bug to me
is a fix planned for next release?
Zachery
09-24-2006, 04:57 PM
Its not a bug so much, its a feature working as its designed too.
Cobra SA
09-25-2006, 03:47 PM
Lies! :P

they aren't supposed to show like that
http://img213.imageshack.us/img213/3454/couperm2.jpg

there should be a linebreak between attachement
obviously a bug
Zachery
09-25-2006, 04:04 PM
Sorry, I totally thought you were asking about something else.

I'll see if I can get this fixed.
Brian
09-25-2006, 07:09 PM
Thanks for pointing this out. If you'll look in your modules/news.php file for this code:
$news['attachment'] .= '<img class="inlineimg" src="' . $stylevar['imgdir_attach'] . '/' . $attachment['attachmentextension'] . '.gif" alt="' . construct_phrase($vbphrase['file_type_x'], $attachment['attachmentextension']) . '" width="16" height="16" border="0" style="vertical-align:baseline" /> <a href="' . $vbulletin->options['bburl'] . '/attachment.php?' . $session['sessionurl'] . 'attachmentid=' . $attachment['attachmentid'] . '">' . $attachment['filename'] . '</a> (' . vb_number_format($attachment['filesize'], 1, true) . ', ' . construct_phrase($vbphrase['x_views'], $attachment['counter']) . ')';

Replace with this:
$news['attachment'] .= '<div><img class="inlineimg" src="' . $stylevar['imgdir_attach'] . '/' . $attachment['attachmentextension'] . '.gif" alt="' . construct_phrase($vbphrase['file_type_x'], $attachment['attachmentextension']) . '" width="16" height="16" border="0" style="vertical-align:baseline" /> <a href="' . $vbulletin->options['bburl'] . '/attachment.php?' . $session['sessionurl'] . 'attachmentid=' . $attachment['attachmentid'] . '">' . $attachment['filename'] . '</a> (' . vb_number_format($attachment['filesize'], 1, true) . ', ' . construct_phrase($vbphrase['x_views'], $attachment['counter']) . ')</div>';

And that should take care of the problem.
Cobra SA
09-29-2006, 08:16 PM
Worked like a charm :)
Thanks Brian and Zach
You rock!!