PDA

View Full Version : Suggestions


Kirby
04-11-2007, 11:47 AM
Create module cache with module id as key
This way, it would be possible to loop though the active modules for the page instead of looping through the whole module list
=> shorter loop
Create a bitfield for modules:
[ ] Apply Usergroup Permissions
[ ] Parser Required
[ ] Forum permissions Required
[ ] Ignorelist required
[ ] Moderators required
In _top.php build combined permissions settings an load only the required stuff in _bottom.php
Also, only check usergroups if the module requires it
Same permission thing for pages
Always use absolute includes, avoid using require_once if possible
This has can give advantages in cached opcode environments
Also, the chdir() call could be skipped
Don't assign modules to fixed columns
Instead, when adding a module to a page let the user select the column there
Allow overwrting files when importing modules
Import module templates to MASTER style
Page editing is way too complicated because of all the module settings
Might be better to just show the assigned modules, with links to remove them or edit their properties.
Some Hooks would be nice:
- In update_page_cache(), update_module_cache() before the datastore gets updated - would also require to read all columns from the tables
- In general section when adding/updating page
- In ACP page type switch when adding/editing a page -> default section with hook to handle custom types
- In _bottom.php to process custom types

Brian
04-11-2007, 03:13 PM
Thanks for the feedback Kirby. A couple of the things you've mentioned have already been done in the v2.5 dev files. Good points/ideas on the rest, and I'm sure I'll be able to get a few worked into 2.5. :)

Our Sponsors
 

Kirby
04-12-2007, 04:52 AM
One really important thing (at least for me):

Currently, vBAdvanced CMPS massively uses global namespace.
This is becoming a major PITA when integrating modules with other scripts.

Therefore I suggest to keep global namespace usage at a minimum (eg. execute modules in function/method context, etc.)

Kirby
04-13-2007, 12:09 PM
One more thing:

- Add a setting to use <base /> instead of header/footer/navbar/headinclude replacements