PDA


View Full Version : Found a bug regarding attachments and the news module.


97cobracpe
06-10-2007, 11:39 AM
I had a memember today tell me that they could not download one of the attachments on the board (a doc file). After investigating I found a typo in the adv_portal_newsbits_attach_inline template.

This part in that template looked fishy.. <a href="$vbulletin->options[bburl]/attachment.php?$session[sessionurl]attachmentid=$attachment[attachmentid]">$attachment[filename]</a>

I checked out the template used for the thunbmails and the statement used to show the thumbnails was different, so I changed the inline one to match since thumnails worked fine. Voila, my problem was fixed.

<a href="$vboptions[bburl]/attachment.php?$session[sessionurl]attachmentid=$attachment[attachmentid]">$attachment[filename]</a>

Just thought I'd let others know, incase someone else has the same problem.

Brian
06-10-2007, 11:49 AM
Thank you for pointing this out. The attachment stuff was originally just printed within the news.php file, so it looks like I forgot to change that variable when I moved it from the file into a template. I'll be sure that's corrected with the next release.

quantnet.org
07-08-2007, 10:57 PM
Had the same problem, the fix posted solved this but my VBA shows that adv_portal_newsbits_attach_inline template is uncached.

Anyone found the samething ?

Brian
07-09-2007, 08:44 AM
That should have been added to the 'Templates Used' section for that module when you upgraded. If it wasn't, just edit the module, add it to the list, and that should take care of the problem.