Install Bug

[jw0ollard]

The install script overwrote some of my custom CSS Values in the style manager.

For instance, I don't have a "thead" background image, and it went and decided to put it back in there. It did the same for Panel and Panel Surround. I assume it would have done the same for tcat, but I had an image in that setting.

I'm a little P'O'ed... I'm just glad it didn't do any more damage. *Backs up style* :)

----

Also, just now I got "Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/functions_vba_links.php on line 766" on the Links' search.php page.

Does vBa Links not integrate with vBadvanced? Well, scratch that, it seems to integrate fine with the rest of the pages. Just not search.php.


----------

Also, may as well add that for whatever reason my custom BBCode images are NOT loading in the editor inside the links pages. Well, most of them aren't. The URL looks like "http://www.domain.com/forums/http://www.domain.com/forums/images/editor/custombbcode.gif" ??? Also, when I get to an error page in "browselinks.php" the "please notify the administrator" link leads directly to my email... I need to fix that right away!!

Also, I've noticed the reply area on a showlinks page is very small, like what happened with the first version of 3.6.8 or whatever, which they eventually fixed.

-- I'm just posting these as I find them, I haven't even looked into whether there are already solutions posted on the board. My post was initially just to report that install error, but it has since branched out a little. :)

[jw0ollard]

I searched this thread for "Quick Reply" but couldn't find anybody mentioning it..

If you just copy the quickreply from SHOWTHREAD into ADV_LINKS_SHOWLINK that seems to fix the QR problem. (Well, of course, you have to leave the specific links stuff, like the form code and the hidden input fields)

[Our Sponsors]

[Brian]

The install script overwrote some of my custom CSS Values in the style manager.

For instance, I don't have a "thead" background image, and it went and decided to put it back in there. It did the same for Panel and Panel Surround. I assume it would have done the same for tcat, but I had an image in that setting.

I'm a little P'O'ed... I'm just glad it didn't do any more damage. *Backs up style* :)
Was this from using the install file that you just downloaded today, or were you using an older version? There was an issue like you're describing, but that should have been corrected a couple of month ago or so.


Also, just now I got "Warning: in_array() [function.in-array]: Wrong datatype for second argument in /includes/functions_vba_links.php on line 766" on the Links' search.php page.

Does vBa Links not integrate with vBadvanced? Well, scratch that, it seems to integrate fine with the rest of the pages. Just not search.php.
Admin CP => vBa Links Directory => Modify Settings => Main Options

Try going there, save the settings, and see if that helps. It sounds like your settings cache just may not have been updated properly.

Also, may as well add that for whatever reason my custom BBCode images are NOT loading in the editor inside the links pages. Well, most of them aren't. The URL looks like "http://www.domain.com/forums/http://www.domain.com/forums/images/editor/custombbcode.gif" ???
If you edit the image paths you're using so that they just point to 'images/whatever' instead of using the full URL (http://domain.com/forum/images/whatever) then that should take care of that issue.

Also, when I get to an error page in "browselinks.php" the "please notify the administrator" link leads directly to my email... I need to fix that right away!!
That should link to whatever email address you've specified for your 'Contact Email' in the Admin CP.

[jw0ollard]

Was this from using the install file that you just downloaded today, or were you using an older version? There was an issue like you're describing, but that should have been corrected a couple of month ago or so.

That should link to whatever email address you've specified for your 'Contact Email' in the Admin CP.

I just downloaded it today. I don't think I've even downloaded vBa Links on this specific computer I'm on.. but I guess I could double check. Edit: It was definitely the one I downloaded today.

The fatal error disappeared, so I guess it was cache related.

What I mean is why isn't it linking to "sendmessage.php" like the error messages on the board? I think it'd be a big problem if spammers came to that page.

[Our Sponsors]

[Brian]

What I mean is why isn't it linking to "sendmessage.php" like the error messages on the board? I think it'd be a big problem if spammers came to that page.
Errr, it looks like an old variable may have still been in use on that page. If you will look in the browselinks.php file for this line though:
eval(standard_error(fetch_error('noid', $vbphrase['category'], $vbulletin->options['webmasteremail'])));

And replace with this:
eval(standard_error(fetch_error('noid', $vbphrase['category'], $vbulletin->options['contactuslink'])));

Then that should take care of the problem.

[jw0ollard]

Errr, it looks like an old variable may have still been in use on that page. If you will look in the browselinks.php file for this line though:
eval(standard_error(fetch_error('noid', $vbphrase['category'], $vbulletin->options['webmasteremail'])));

And replace with this:
eval(standard_error(fetch_error('noid', $vbphrase['category'], $vbulletin->options['contactuslink'])));

Then that should take care of the problem.

Actually, it doesn't even say my email anymore.. haha. It says ARG:2[UNDEFINED] or something to that extent. (The syntax may be off, doing that from memory)

I'll try this fix though.

So can you confirm this quick reply problem? Copying the new QR code from 3.6.8 fixes it.

[Brian]

So can you confirm this quick reply problem? Copying the new QR code from 3.6.8 fixes it.

Yes, some things with the Quick Reply box were changed during one of the last vB releases. The "official" fix will be to look in the 'ADV_LINKS_SHOWLINK' template for this code:
<table cellpadding="0" cellspacing="0" border="0" align="center">
<tr>
<td class="smallfont" align="$stylevar[left]">$vbphrase[message]:</td>
</tr>
<tr>
<td id="$editorid" class="vBulletin_editor" align="$stylevar[left]">$messagearea</td>
</tr>
<tr>
<td align="$stylevar[left]">

<fieldset class="fieldset" style="padding:$stylevar[formspacer]px 0px 0px 0px">
<legend>$vbphrase[options]</legend>
<div>
<if condition="$bbuserinfo['signature']">
<div style="float:$stylevar[right]"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="5" checked="checked" />$vbphrase[show_your_signature]</label></div>
</if>
<label for="qr_quickreply"><input type="checkbox" name="quickreply" value="1" id="qr_quickreply" accesskey="w" tabindex="4" />$vbphrase[quote_message_in_reply]</label>
</div>
</fieldset>

</td>
</tr>
</table>
</div>


And replace with this:
<div align="$stylevar[left]" style="max-width:$stylevar[messagewidth]; width:auto !important; width:$stylevar[messagewidth]">
<div class="smallfont">$vbphrase[message]:</div>
<div id="$editorid" class="vBulletin_editor">$messagearea</div>
<fieldset class="fieldset" style="padding:$stylevar[formspacer]px 0px 0px 0px">
<legend>$vbphrase[options]</legend>
<div>
<if condition="$bbuserinfo['signature']">
<div style="float:$stylevar[right]"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="5" checked="checked" />$vbphrase[show_your_signature]</label></div>
</if>
<label for="qr_quickreply"><input type="checkbox" name="quickreply" value="1" id="qr_quickreply" accesskey="w" tabindex="4" />$vbphrase[quote_message_in_reply]</label>
</div>
</fieldset>
</div>