Go to new post fragment...

[zacarias]

I had a smooth upgrade of my board from 3.7 Beta 4 to Beta 6.
Then, I began seeing this when someone clicks go to new post, or go to last post:

-1)) { fetch_object('currentPost').scrollIntoView(true); }">

Right above the reply to thread button at the top of the thread.

Board: www.i6boards.com

So, I updated the CMPS to the latest version, and it's still there.
It's not the skin that I designed, because everything worked fine before, and the forum works fine when the CMPS is disabled. Any help on this issue? I don't want to edit the source code of the CMPS if I don't have to. :)

[Mephisteus]

Same thing, same upgrade, same update to CMPS, forums work fine when CMPS is disabled aswell.

www.group-17.com

[Tarto]

same here!

[zacarias]

That's strange. It's not really a gigantic problem, but it's still annoying to see it.

[Black Tiger]

Same problem here, was not present in 3.7.0 b5, but it is in 3.7.0 b6.

[Black Tiger]

Got another one, probably caused by the same problem.

When viewing "currently active users" in the upper left corner of the forums this appears:
";

[zacarias]

I don't have that issue... :(

[Mephisteus]

And me neither

[zacarias]

Well just thought I'd give the mods more info about this...

This is using integration, and the problem is with integration and showthread.php when it's supposed to snap to a single post (such as showthread.php?p=720634#post720634)

Also, I noticed there is an error (I have firebug an extension for firefox), that says there's an "invalid XML attribute value" in showthread.php line 4. I've confirmed the same error on the group-17's website using firebug.

Since so many of us seem to have this error, shouldn't it be put in the bug section? Many people seem to be able to reproduce this.

[burntire]

When ever you go to a new thread and click View First Unread the following code appears above the first post.

-1)) { fetch_object('currentPost').scrollIntoView(true); }">

This only occurs when viewing a thread that has multiple pages and using View First Unread is used.

I disabled all plugins 1 by 1 and vbadvanced disabling clears the issue.

Example by clicking View First Unread
http://www.highperformancestangs.com/forums/showthread.php?p=35778#post35778

Example by not using View First Unread
http://www.highperformancestangs.com/forums/showthread.php?t=4054&page=6

[burntire]

Got another one, probably caused by the same problem.

When viewing "currently active users" in the upper left corner of the forums this appears:

That is fixable.

Look for the extra "; in the whois online template and remove it.

Find this
<meta http-equiv="refresh" content="$vboptions[WOLrefresh]"; url=online.php?$session[sessionurl]order=$sortorder&amp;sort=$sortfield&amp;pp=$perpage&amp;page=$pagenumber$refreshargs />";

Replace with this<meta http-equiv="refresh" content="$vboptions[WOLrefresh]"; url=online.php?$session[sessionurl]order=$sortorder&amp;sort=$sortfield&amp;pp=$perpage&amp;page=$pagenumber$refreshargs />

[drumbo]

It doesn't do it when you turn off page integration

[Black Tiger]

@Burntire: So that would be a vbulletin bug c.q. code mistake.
Thank you very much for the fix!!

Hopefully somebody can fix the "fetch_object" line problem too.

[KW802]

Scroll into view is a posbit javascript function.

Does the problem also occur when you view the integrated page with the default style?

Also, besides trying the default style are you running any CMPS modules other than the stock modules? If so, try turning them off one-by-one on the page to see if the problem is with any malformed HTML in the custom modules.

[burntire]

Scroll into view is a posbit javascript function.

Does the problem also occur when you view the integrated page with the default style?

Also, besides trying the default style are you running any CMPS modules other than the stock modules? If so, try turning them off one-by-one on the page to see if the problem is with any malformed HTML in the custom modules.

It occurs on the default style also. I turned of modules one by one and the issue does not go away unless I totally turn off vbadvanced.

[Black Tiger]

Yep indeed. I have a default style, no templates changed, it happens also.

By the way... a little typo on some places here, it's not 3.7.6 it's 3.7.0 beta 6.:)

[Skipsoutdoors]

Same problem for me with the showthread.php. I think I wore out my welcome at vB asking about it, they sent me back here. It looks like they changed something between b5 and b6 but they won't say what it is.

Skip

[burntire]

I am sure Brian will get it worked out. He always does.

[Brian]

vB added some new javascript to the SHOWTHREAD template within the body tag in beta 6, and that javacript contains a > tag which is throwing off the CMPS a bit since it thinks that tag marks the end of the <body> tag. I've spent about an hour this morning trying to find a good solution for the problem, but haven't had much luck so far. As soon as I'm able to come up with a good fix though I'll reply back here.

[Black Tiger]

Great Brian. Thanks for looking at it! I'm sure we all appreciate it.

[Black Tiger]

@Brian I have an update for you.

I was talking to vtec44 on vbulletin.com and he did not have this problem on his forums running 3.7.0 beta 6. So I checked and indeed there was no problem.
However, he had no side-columns on his forums. This gives me the impression that the problem might be found in the integration part of vBA.

Maybe this is of any help to you, I don't know but I thought I just post it so you know.

[Brian]

For those that are having this problem, I've just updated the forum/includes/vba_cmps_include_top.php file to include a fix for this. If you will download the files from here again and replace that file on your server with the updated version, that should take care of the issue. Or, if you would rather apply the fix manually, just open the file, look for this code:
if ($bodytag)
{
$bodycut = strpos($nonindex, '>', $bodytag);
$newheader = substr($nonindex, 0, $bodycut + 1);
$nonindex = substr($nonindex, $bodycut + 1);
}

Replace with this:
if ($bodytag)
{
// Work around for <body> tags that could contain js with >'s
preg_match('#<body(\s+\w+\s*=\s*(("|\').*?(?<!\\\)\3))*>#s', $nonindex, $bmatches);
$bodycut = strlen($bmatches[0]) + $bodytag + 1;
$newheader = substr($nonindex, 0, $bodycut);
$nonindex = substr($nonindex, $bodycut);
}


And that should take care of the issue.

[Mephisteus]

It *does* take care of the issue, thanks Brian :)

[Crimm]

Thank you.

This took care of me as well, and I posted this link back to VB.com's bug report b/c I thought it was a BETA bug ;)

Thank you again!

[burntire]

Thanks for the fix.

[Skipsoutdoors]

Thanks Brian. You the man.

Skip

[Black Tiger]

Brian you're great! Fixed worked for me too, thanks!!

[Tarto]

thank you!!

[zacarias]

Thank you for your timely response and fix Brian! :D

[jGas]

thanks a lot, that's workin'!

[jim6763nva]

Awesome! I just applied the fix too and it worked great! Thank you soooo much Brian! :D

[storpappa]

Thanks, fixed my issue. Are there any opther 3.7 tweaks to apply?

[Brian]

v3.0.1 has been released to deal with all issues with vB 3.7.