Get [Read More] link like it was on vba 2.x

[Nzo]

Hi,

I'm running VB 3.7.1

I just upgrade my old vbadvanced script from 2.x to 3.0.1 (latest package available), the upgrade went ok but I wish to get the [Read More] link of the News module like it was on vbadvanced 2.x series.
Mainly because it make no sense for readers to have the "... Read More" so far from the end of the cut text and also because it's not really nice to have so much useless space.

First an image of what I am talking about :

Problem fix... Image Deleted

Because the "..." are inside $news[message] (modules -> news.php), there is nothing to do in tweaking the $vbphrase[read_more]

[KW802]

Are you sure the spacing isn't because of any other items, like BB Code or something else in the post? I just checked my sites and none of them are showing the 'read more' text like your example.

[Our Sponsors]

[Nzo]

Are you sure the spacing isn't because of any other items, like BB Code or something else in the post? I just checked my sites and none of them are showing the 'read more' text like your example.
Well ok I just check it I find what could be wrong :
The spacing and bottom left position of the "...[read more]" seem related to the BBcode.

[indent] is a default vbulletin bbcode I don't know what could be wrong, maybe script in news.php is not closing/parsing this tag correctly ?

[I]side note : parsing/closing [indent] was ok on my old 2.x vbadvanced

[Nzo]

Sorry to bump thread but I'm still looking for help/fix :

Here is where I am :

"News parsing script" print this html code when an BBcode is used in post :

<blockquote>Thread text and code</blockquote>...<span class="smallfont">[<a href="http://www.yourdomain.com/showthread.php">Read More</a>]</span>

Using <blockquote> seems to be ok, but in this case <blockquote> should be close after the <span> of the $vbphrase[read_more] not before.

It should be :
<blockquote>Thread text and code ...<span class="smallfont">[<a href="http://www.yourdomain.com/showthread.php">Read More</a>]</span></blockquote>

Well i'm not very good in php coding but i think you need to do not auto close <blockquote> tag right before the "..." and the $vbphrase[read_more].

Maybe adding a special condition for <blockquote> tag closing under or near [I]"// ##### Now check normal HTML tags" in news.php should make the trick.

I don't know how to do it but any help is welcome. :)

[Our Sponsors]

[Brian]

Sorry, but I don't think there's really anything that can be done about that since the section that cuts off code and adds any missing ending tags is not capable of adding them after the "Read More" link.

[Nzo]

Sorry, but I don't think there's really anything that can be done about that since the section that cuts off code and adds any missing ending tags is not capable of adding them after the "Read More" link.Thx for your reply.
I already manage to fix it and it's ok.
Maybe I forget something else (i will see later) but after adding a new detecting code to find non close <blockquote> tag (and not auto close it), I just put a new condition :

if ($blockquote==1)
$news['message'] .= '...' . construct_phrase($vbphrase['read_more'].'</blockquote>', $vbulletin->options['bburl'], $news['threadid'], $vbulletin->session->vars['sessionurl']);
else
$news['message'] .= '...' . construct_phrase($vbphrase['read_more'], $vbulletin->options['bburl'], $news['threadid'], $vbulletin->session->vars['sessionurl']);