Results 1 to 13 of 13

Thread: Two minor problems I've noticed.

  1. #1
    Senior Member
    Join Date
    Apr 2005
    Posts
    137

    Default Two minor problems I've noticed.

    Ok, first, I haven't read up on everything here (time issues) so I don't know if these have been pointed out. However, here they are.

    1) There is a rogue element (possibly a <br />) in between the news post and the news archive. It is my assumption that the module spacer var is what is supposed to separate these, and in all cases does, except this one.

    I haven't snooped out where it's coming from yet, and may not, but it should be fixed regardles as it messes with the visual impact.

    To see this in action: http://www.starletrealm.net/ (In development)

    2) When using integration to wrap pages in vbulletin, an issue arises when one of those pages redirects to an error page. For example, and search returning an empty set. The error page is also displaying the navbar, so there's two.

    Of course, the temp workaround is to edit the error shell and remove that, but there should be a more permanent solution.
    2 owned vB licenses and proud of it.

  2. #2
    Senior Member
    Join Date
    Apr 2005
    Posts
    137

    Default Re: Two minor problems I've noticed.

    Ok, in regards to the space issue, I looked at the resultant HTML and found this in between the news and archive.

    <div style="padding-bottom: 15px"></div>

    After looking at the module php, I can only assume that if pagination is not enabled, or needed, an empty wrapper is still being writtin to the page. That should point you in the right direction there.
    2 owned vB licenses and proud of it.

  3. #3
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default Re: Two minor problems I've noticed.

    Thank you for pointing these things out.

    1). It looks like this is due to a small problem where it's checking just the limit for news posts instead of the total for the news and archive. If you will look in your forum/modules/news.php file for this line:
    PHP Code:
    if ($mod_options['portal_news_maxposts'] AND ($newsrows >= $mod_options['portal_news_maxposts'] OR $vbulletin->GPC[$newspagevar])) 
    And replace with this:
    PHP Code:
    if (($mod_options['portal_news_maxposts'] AND ($newsrows >= ($mod_options['portal_news_maxposts'] + $mod_options['portal_news_enablearchive'])) OR $vbulletin->GPC[$newspagevar])) 
    Then that *should* take care of the issue.


    2). Integration isn't *supposed* to be applied to error pages like that, but it looks like the code to prevent the integration from happening was inadvertantly removed in 3.0.1. If you will go to Admin CP => Plugins & Products => Plugin Manager, edit the 'vBa CMPS - Error Replacements' plugin and add this line at the very bottom (after the last } bracket), then that should take care of that issue as well.
    PHP Code:
    define('SKIP_OUTPUT'true); 

  4. #4
    Senior Citizen eJM's Avatar
    Join Date
    Jul 2006
    Location
    teh Ether
    Posts
    322

    Default Re: Two minor problems I've noticed.

    Did you apply these changes to the package, Brian, or do I have to manually enter them when I upgrade?

    Thanks,

    Jim
    If my post was helpful to you, or made you or ,
    please take the time to register at my forum and ask
    a question you've always wanted to know about floors.

  5. #5
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default Re: Two minor problems I've noticed.

    Both of these changes have been applied to the download package here.

  6. #6
    Junior Member
    Join Date
    Jan 2007
    Posts
    4

    Default Re: Two minor problems I've noticed.

    Are you sure the fix for the extra space between the News and News Archive has been applied to the download package? I'm still seeing the space on my site.

  7. #7
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default Re: Two minor problems I've noticed.

    It should have been, but upon further review of the file there may have still been a small error. Try downloading the files from here again, replace your modules/news.php file with the one from the download package, and see if that helps.

  8. #8
    Junior Member
    Join Date
    Jan 2007
    Posts
    4

    Default Re: Two minor problems I've noticed.

    Hi Brian, nope still the same.

  9. #9
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default Re: Two minor problems I've noticed.

    I'm not sure why you would still be having the problem, but if you would like to submit a support ticket via the Members' Area here I'll be glad to take a look at things for you.

  10. #10
    Senior Member
    Join Date
    Jan 2008
    Posts
    158

    Default

    Just noticed the second issue as well...an extra set of div tags that shouldn't be there seem to exist, creating extra space between the news module and the module below it. The extra code is:

    <div style="padding-bottom: 18px"></div>
    18px is what I set my horizontal spacing between modules. I upgraded to the latest version of vbadvanced but its still there.

    I checked for your PHP code in the plugin manager under the error replacements plugin and I saw its already there.
    PHP Code:
    define('SKIP_OUTPUT'true); 
    Can you tell me what you did to fix this problem?

  11. #11
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default

    Which site is this that you're having the issue on?
    xed never submitted a ticket, so I'm not sure what the fix was in their case.
    Frequently Asked Questions
    CMPS Users Manual

    For vBadvanced software assistance, please use the support forums.
    Unsolicted PMs, IMs, and email will not be responded to.
    If you have a non-software related question or problem with your account, please submit a support ticket.

  12. #12
    Senior Member
    Join Date
    Jan 2008
    Posts
    158

    Default

    Quote Originally Posted by Brian View Post
    Which site is this that you're having the issue on?
    xed never submitted a ticket, so I'm not sure what the fix was in their case.
    I will PM you the site I am having trouble.

  13. #13
    Administrator Brian's Avatar
    Join Date
    Jan 2004
    Location
    Georgia, USA
    Posts
    34,465

    Default

    I'm not seeing any obvious causes there, but if you would like to submit a support ticket I'll be glad to take a look at things for you.
    Frequently Asked Questions
    CMPS Users Manual

    For vBadvanced software assistance, please use the support forums.
    Unsolicted PMs, IMs, and email will not be responded to.
    If you have a non-software related question or problem with your account, please submit a support ticket.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Similar Threads

  1. Fort Minor fan? Check out fort minor world!
    By jnuts in forum Show off your vBadvanced!
    Replies: 1
    Last Post: 04-30-2008, 09:51 PM
  2. I just noticed something irritating.
    By shortbus in forum Feedback & Suggestions
    Replies: 1
    Last Post: 11-08-2006, 08:46 PM
  3. Minor changes for admincp
    By StewardManscat in forum Add-On Modules & Modifications
    Replies: 0
    Last Post: 03-22-2005, 02:10 PM
  4. Minor Problem
    By joeychgo in forum Troubleshooting / "How do I..." Questions
    Replies: 16
    Last Post: 11-21-2004, 05:55 PM
  5. Minor bug - welcome block
    By ogetbilo in forum Bugs & Other Issues
    Replies: 7
    Last Post: 05-18-2004, 08:03 AM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •