Uploading new smilies adds sites full url

[Cyricx]

Okay, when uploading new smilies you have to go back afterwords and edit the smilie to add the full url path for the smilie to show up on the mainpage.

Which is increasingly annoying.

Anyone know how to edit like the insert function in the admincp/images.php file so that the mysql query will add the full url for the site?

[Brian]

Upload the vbacmps_install.php file to your admincp directory, go to it in your browser, and select the option to update your image paths.

[Cyricx]

only problem there is you have to go through all of your smilies

Instead of just the ones that are not yet done.

So it can make a huge board like mine with well over 200 smilies, a headache to go through to update 30 heheeh.

Anyway I can add an if statment or something to the file to only show the ones that need to be updated?

[Brian]

First look for this query:

PHP Code:

            $countsmilies = $db->query_first("SELECT COUNT(*) AS count FROM " . TABLE_PREFIX . "smilie"); 


Replace with this:

PHP Code:

            $countsmilies = $db->query_first("SELECT COUNT(*) AS count FROM " . TABLE_PREFIX . "smilie WHERE smiliepath NOT LIKE '" . $vbulletin->options['bburl'] . "%'"); 


Then find:

PHP Code:

            $smilies = $db->query("
                    SELECT * FROM " . TABLE_PREFIX . "smilie
                    ORDER BY smilieid
                    LIMIT " . ($minlimit - 1) . ", $perpage
            "); 


Replace with this:

PHP Code:

            $smilies = $db->query("
                    SELECT * FROM " . TABLE_PREFIX . "smilie
                    ORDER BY smilieid
                    WHERE smiliepath NOT LIKE '" . $vbulletin->options['bburl'] . "%'
                    LIMIT " . ($minlimit - 1) . ", $perpage
            "); 


And that should only pull smilies that have not already been prefixed.

[Cyricx]

Awesome bro! Thanks so much!

[KW802]

Brian, for sites that have a lot of smilies that's a nice change. Any chance of getting that in the stock code for the next release?

[Brian]

I don't see why it would hurt anything.

*Adds code to dev files*

[KW802]

Originally Posted by Brian

I don't see why it would hurt anything.

*Adds code to dev files*

Excellent! I know from first-hand experience with helping people re-install CMPS after a vB upgrade that for sites that have a lot of smilies that this change will a very nice timesaver.

It's the little touches that are the hallmarks of quality.