Two minor problems I've noticed.

[Albus]

Ok, first, I haven't read up on everything here (time issues) so I don't know if these have been pointed out. However, here they are.

1) There is a rogue element (possibly a <br />) in between the news post and the news archive. It is my assumption that the module spacer var is what is supposed to separate these, and in all cases does, except this one.

I haven't snooped out where it's coming from yet, and may not, but it should be fixed regardles as it messes with the visual impact.

To see this in action: http://www.starletrealm.net/ (In development)

2) When using integration to wrap pages in vbulletin, an issue arises when one of those pages redirects to an error page. For example, and search returning an empty set. The error page is also displaying the navbar, so there's two.

Of course, the temp workaround is to edit the error shell and remove that, but there should be a more permanent solution.

[Albus]

Ok, in regards to the space issue, I looked at the resultant HTML and found this in between the news and archive.

<div style="padding-bottom: 15px"></div>

After looking at the module php, I can only assume that if pagination is not enabled, or needed, an empty wrapper is still being writtin to the page. That should point you in the right direction there.

[Brian]

Thank you for pointing these things out.

1). It looks like this is due to a small problem where it's checking just the limit for news posts instead of the total for the news and archive. If you will look in your forum/modules/news.php file for this line:

PHP Code:

if ($mod_options['portal_news_maxposts'] AND ($newsrows >= $mod_options['portal_news_maxposts'] OR $vbulletin->GPC[$newspagevar])) 


And replace with this:

PHP Code:

if (($mod_options['portal_news_maxposts'] AND ($newsrows >= ($mod_options['portal_news_maxposts'] + $mod_options['portal_news_enablearchive'])) OR $vbulletin->GPC[$newspagevar])) 


Then that *should* take care of the issue.


2). Integration isn't *supposed* to be applied to error pages like that, but it looks like the code to prevent the integration from happening was inadvertantly removed in 3.0.1. If you will go to Admin CP => Plugins & Products => Plugin Manager, edit the 'vBa CMPS - Error Replacements' plugin and add this line at the very bottom (after the last } bracket), then that should take care of that issue as well.

PHP Code:

define('SKIP_OUTPUT', true); 


[eJM]

Did you apply these changes to the package, Brian, or do I have to manually enter them when I upgrade?

Thanks,

Jim

[Brian]

Both of these changes have been applied to the download package here.

[xed]

Are you sure the fix for the extra space between the News and News Archive has been applied to the download package? I'm still seeing the space on my site.

[Brian]

It should have been, but upon further review of the file there may have still been a small error. Try downloading the files from here again, replace your modules/news.php file with the one from the download package, and see if that helps.

[xed]

Hi Brian, nope still the same.

[Brian]

I'm not sure why you would still be having the problem, but if you would like to submit a support ticket via the Members' Area here I'll be glad to take a look at things for you.

[sfnet]

Just noticed the second issue as well...an extra set of div tags that shouldn't be there seem to exist, creating extra space between the news module and the module below it. The extra code is:

<div style="padding-bottom: 18px"></div>

18px is what I set my horizontal spacing between modules. I upgraded to the latest version of vbadvanced but its still there.

I checked for your PHP code in the plugin manager under the error replacements plugin and I saw its already there.

PHP Code:

define('SKIP_OUTPUT', true); 


Can you tell me what you did to fix this problem?

[Brian]

Which site is this that you're having the issue on?
xed never submitted a ticket, so I'm not sure what the fix was in their case.

[sfnet]

Originally Posted by Brian

Which site is this that you're having the issue on?
xed never submitted a ticket, so I'm not sure what the fix was in their case.

I will PM you the site I am having trouble.

[Brian]

I'm not seeing any obvious causes there, but if you would like to submit a support ticket I'll be glad to take a look at things for you.