Facebook redirection rears its ugly head again

[TeknoSounds]

Hey Brian, just updated my dev site to 4.1.1 and immediately noticed it was forcing me to log in via Facebook. Based off the previous ticket I had opened, I was able to find and correct the issue.

In the Query Page Data plugin we have:
Current, Incorrect

if ((do_facebook_redirect() AND 
            ($vbulletin->userinfo['userid'] AND $vbulletin->userinfo['fbuserid'] != vB_Facebook::instance()->getLoggedInFbUserId())
            OR (!$vbulletin->userinfo['userid'] AND !vB_Facebook::instance()->getVbUseridFromFbUserid()))
        )

Corrected (removed first paren and moved it down in front of the $vbulletin variable)

if (do_facebook_redirect() AND 
            (($vbulletin->userinfo['userid'] AND $vbulletin->userinfo['fbuserid'] != vB_Facebook::instance()->getLoggedInFbUserId())
            OR (!$vbulletin->userinfo['userid'] AND !vB_Facebook::instance()->getVbUseridFromFbUserid()))
        )

[Brian]

Thank you for pointing this out. I'm not sure how that change got left out, but I've went ahead and updated the install file in the download package here to include the correct code so it shouldn't be an issue for future installs.

[MortysTW]

Having the same issue.

Can you explain where I can make this tweak myself without having to reload vBa? I just upgraded last week and really don't want to do it again if it's a simple tweak I can go make.

Please and thank you.

[Brian]

Just go to Admin CP => Plugins & Products => Plugin Manager, edit the plugin called 'Query Page Data', and replace the 'Plugin PHP Code' with the following:

PHP Code:

if (defined('VBA_PORTAL'))
{
    // ##### Facebook Redirect
    if (THIS_SCRIPT == 'adv_index' AND function_exists('is_facebookenabled') AND is_facebookenabled() AND $show['facebookuser'] = vB_Facebook::instance()->userIsLoggedIn())
    {
        if (do_facebook_redirect() AND 
            (($vbulletin->userinfo['userid'] AND $vbulletin->userinfo['fbuserid'] != vB_Facebook::instance()->getLoggedInFbUserId())
            OR (!$vbulletin->userinfo['userid'] AND !vB_Facebook::instance()->getVbUseridFromFbUserid()))
        )
        {
            exec_header_redirect($vbulletin->options['bburl'] . '/register.php' . $vbulletin->session->vars['sessionurl_q']);
        }
    }

    global $phrasegroups;

    // Figure out which page to grab
    $pagevar = false;
    if (THIS_SCRIPT == 'adv_index')
    {
        $pagevar = $vbulletin->adv_portal_opts['adv_portal_main']['portal_pagevar'];
    }

    if (defined('VBA_PAGE'))
    {
        $getpage = VBA_PAGE;
    }
    else if($pagevar AND isset($_REQUEST[$pagevar]))
    {
        $getpage = $_REQUEST[$pagevar];
    }
    else
    {
        $getpage = 'home';
    }

    $initialize_dynamics = false;

    ($hook = vBulletinHook::fetch_hook('vba_cmps_include_getpage')) ? eval($hook) : false;

    // ##### Now grab the page
    if ($getpage == 'home')
    {
        $pages =& $vbulletin->adv_portal_home;
    }
    else
    {
        $pages = $db->query_first("
            SELECT *
            FROM " . TABLE_PREFIX . "adv_pages
            WHERE name = '" . $db->escape_string($getpage) . "'
                " . iif(!($permissions['adminpermissions'] & $vbulletin->bf_ugp_adminpermissions['cancontrolpanel']), 'AND active = 1')
        );

        $pages['modules'] = unserialize($pages['modules']);
        $pages['userperms'] = explode(',', $pages['userperms']);
        $pages['advanced'] = unserialize($pages['advanced']);
        $pages['meta'] = unserialize($pages['meta']);
    }

    $vbulletin->adv_pages =& $pages;

    if (!empty($pages['modules']))
    {
        foreach ($pages['modules'] AS $pagecol => $pagemodules)
        {
            if (!empty($pagemodules))
            {
                foreach ($pagemodules AS $advmodid => $advmodorder)
                {
                    if ($vbulletin->adv_modules[$advmodid]['dyna_prefix'])
                    {
                        $initialize_dynamics = true;
                        $phrasegroups[] = $vbulletin->adv_modules[$advmodid]['dyna_prefix'];
                    }
                }
            }
        }
    }
}
else if (defined('VBA_CMPS_ADMIN_FILE') AND in_array($_REQUEST['do'], array('addmodule', 'editmodule', 'copymodule', 'addpage', 'editpage', 'copypage', 'modifysettings')))
{
    global $phrasegroups;
    $getdyna = false;
    if (!empty($vbulletin->adv_modules))
    {
        foreach ($vbulletin->adv_modules AS $modid => $mod)
        {
            if ($mod['dyna_prefix'])
            {
                $getdyna = true;
            }
        }

        if ($getdyna)
        {
            $phrasegroups[] = 'adv_dyna';
            $phrasegroups[] = 'adv_dyna_cp';
        }
    }
}
else if ($vbulletin->options['vba_portal_navtabs'])
{
    $datastore_fetch[] = "'adv_portal_page'";
} 


[MortysTW]

And now it works. Thank you very much! Much appreciated as always.